Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for provider.alb.authorizers[].allowAuthenticated #8120

Closed
medikoo opened this issue Aug 24, 2020 · 2 comments · Fixed by #8160
Closed

Remove support for provider.alb.authorizers[].allowAuthenticated #8120

medikoo opened this issue Aug 24, 2020 · 2 comments · Fixed by #8160
Assignees
@morgan-sam
Labels
breaking A breaking change cat/aws-event-alb good first issue help wanted
Milestone
v2

Comments

@medikoo
Copy link
Contributor

medikoo commented Aug 24, 2020 •
edited
Loading

Use case description

With #7773 we've deprecated allowUnauthenticated in favor of onUnauthenticatedRequest. For v2 support for allowUnauthenticated should be removed

Proposed solution

Remove support for allowUnauthenticated and its deprecation notice.

PR should be based against v2 branch
@medikoo medikoo added breaking A breaking change cat/aws-event-alb labels Aug 24, 2020
@medikoo medikoo added this to the v2 milestone Aug 24, 2020
@morgan-sam
Copy link
Contributor

Hi I've started to work on this one

@medikoo
Copy link
Contributor Author

medikoo commented Aug 26, 2020

Thank you @morgan-sam !

@morgan-sam morgan-sam mentioned this issue Sep 1, 2020
Merged
@medikoo medikoo closed this as completed Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@morgan-sam morgan-sam

Labels
breaking A breaking change cat/aws-event-alb good first issue help wanted
Projects
None yet
Milestone
v2
Development

Successfully merging a pull request may close this issue.

Remove support for allowUnauthenticated
2 participants
@medikoo @morgan-sam