Deprecate service.awsKmsKeyArn
in favor of provider.kmsKeyArn
#8261
Labels
cat/lambda
deprecation
Deprecation proposal (breaking with next major)
good first issue
help wanted
refactor
Use case description
There's lone AWS provider property to be setup in context of
service
while all others are set in context ofprovider
.Historically (#3672 (comment)) it looks it was added as a start of moving everything from
provider
scope toservice
scope. Still It was not followed, and I don't see a reason, now, why configuration asservice.aws*
is better thanprovider.*
I believe, that for consistency we should move this property to
provider
context. It also makes schema configuration for AWS provider more complex.Proposed solution
provider.kmsKeyArn
(it should shadowservice.awsKmsKeyArn
, butfunctions[].kmsKeyArn
should take precedence)service.awsKmsKeyArn
usagefunctions[].kmsKeyArn
(for consistency) and deprecatefunctions[].awsKmsKeyArn
Implementation should take place here:
serverless/lib/plugins/aws/package/compile/functions/index.js
Lines 257 to 265 in 29d5fe7
Also changes should be reflected in config schema (however schema should maintain support for deprecated properties)
The text was updated successfully, but these errors were encountered: