Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround "Rate exceeded" errors in custom resources #8333

Closed
medikoo opened this issue Oct 2, 2020 · 4 comments · Fixed by #8338
Closed

Workaround "Rate exceeded" errors in custom resources #8333

medikoo opened this issue Oct 2, 2020 · 4 comments · Fixed by #8338
Assignees
@pratik-vii
Labels
cat/deployment enhancement good first issue help wanted

Comments

@medikoo
Copy link
Contributor

medikoo commented Oct 2, 2020

Use case description

Custom resources use plain AWS SDK calls, without any intelligent error handling.

Single "Rate exceeded" error, may fail whole stack upload (as we can observe in this CI fail: https://github.com/serverless/serverless/runs/1198178909)

It'll be great imply retry logic on such recoverable errors

Proposed solution

We probably should add awsRequest util (like one here @serverless/test/aws-request), with implemented recovery logic, to utils.js and rely on this in all places where we invoke AWS SDK
@pratik-vii
Copy link
Contributor

@medikoo I can pick up this task!

@medikoo
Copy link
Contributor Author

medikoo commented Oct 2, 2020

Thank you @pratik-vii ! Go for it

@pratik-vii pratik-vii mentioned this issue Oct 2, 2020
Merged
@pratik-vii
Copy link
Contributor

@medikoo Let's close this issue. Sorry I forgot to add closes tag in PR.

@medikoo
Copy link
Contributor Author

medikoo commented Oct 7, 2020

@pratik-vii closing, thanks for pointing!

@medikoo medikoo closed this as completed Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pratik-vii pratik-vii

Labels
cat/deployment enhancement good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added awsRequest for aws-sdk call backoff and retry in customResources pratik-vii/serverless
2 participants
@medikoo @pratik-vii