Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clean command in aws-go-mod template removes go.sum file #8507

Merged
merged 1 commit into from Nov 16, 2020
Merged

fix: clean command in aws-go-mod template removes go.sum file #8507

merged 1 commit into from Nov 16, 2020

Conversation

pranc1ngpegasus
Copy link
Contributor

Template aws-go-mod is for Go Modules.
It has make clean command on Makefile, but it cleans Gopkg.lock not go.sum.
So I fixed.

@codecov-io
Copy link

Codecov Report

Merging #8507 (9658909) into master (786809e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8507   +/-   ##
=======================================
  Coverage   87.26%   87.26%           
=======================================
  Files         255      255           
  Lines        9503     9503           
=======================================
  Hits         8293     8293           
  Misses       1210     1210           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 786809e...9658909. Read the comment docs.

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @pranc1ngpegasus !

@medikoo medikoo merged commit 2791c71 into serverless:master Nov 16, 2020
@pranc1ngpegasus pranc1ngpegasus deleted the fix_aws-go-mod_has_not_gopkg-lock_file branch November 19, 2020 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants