Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ALB event path optional #8571

Merged
merged 16 commits into from Dec 11, 2020
Merged

Make ALB event path optional #8571

merged 16 commits into from Dec 11, 2020

Conversation

jinhong-
Copy link
Contributor

@jinhong- jinhong- commented Dec 2, 2020

Closes: #8568

ALB event path should have been optional. However omission of the path would result in a failure in deployment. This PR addresses the issue by excluding the path when it is not set

@codecov-io
Copy link

codecov-io commented Dec 2, 2020

Codecov Report

Merging #8571 (bb3af29) into master (8545268) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8571      +/-   ##
==========================================
+ Coverage   86.93%   86.94%   +0.01%     
==========================================
  Files         254      252       -2     
  Lines        9518     9515       -3     
==========================================
- Hits         8274     8273       -1     
+ Misses       1244     1242       -2     
Impacted Files Coverage Δ
...ib/plugins/aws/package/compile/events/alb/index.js 100.00% <ø> (ø)
...ws/package/compile/events/alb/lib/listenerRules.js 84.61% <100.00%> (+0.83%) ⬆️
...ins/aws/package/compile/events/alb/lib/validate.js 95.71% <100.00%> (+0.40%) ⬆️
lib/plugins/standalone/index.js 40.00% <0.00%> (-1.03%) ⬇️
lib/utils/fs/readFileIfExists.js
lib/utils/getTrackingConfigFileName.js

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8545268...bb3af29. Read the comment docs.

@jinhong- jinhong- marked this pull request as ready for review December 2, 2020 16:00
Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jinhong- Great thanks for this PR! Still before I review, let's first agree on right solution in the issue (I've posted the comment there)

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jinhong- Thank you! It looks very good.

Still we've taken a new better approach to testing in last months, and all new tests should follow that. Please check my comment, and let me know if anything is not clear enough

@jinhong-
Copy link
Contributor Author

jinhong- commented Dec 4, 2020

@medikoo Reverted old tests and updated new tests

@jinhong- jinhong- requested a review from medikoo December 4, 2020 18:59
Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jinhong- Looks good, I've just proposed few organization improvements

@jinhong- jinhong- requested a review from medikoo December 9, 2020 03:18
Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jinhong- ! It looks very good. I've proposed just few last improvements

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jinhong- ! It looks great, let's just improve error code

lib/plugins/aws/package/compile/events/alb/lib/validate.js Outdated Show resolved Hide resolved
Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jinhong- !

@medikoo medikoo merged commit 3632e0e into serverless:master Dec 11, 2020
@jinhong-
Copy link
Contributor Author

Thank you @jinhong- !

You're most welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ALB listener path should be optional
3 participants