New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Packaging): Add exec bit for packaged files on Windows #8615
Conversation
Remove Go-specific hacks, set exec bit when packaging on Windows.
Codecov Report
@@ Coverage Diff @@
## master #8615 +/- ##
==========================================
+ Coverage 86.94% 87.01% +0.07%
==========================================
Files 252 252
Lines 9506 9505 -1
==========================================
+ Hits 8265 8271 +6
+ Misses 1241 1234 -7
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@scadu that looks great! I have just one very minor cleanup suggestion, and it'll be ready to go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @scadu !
Closes: #3557