Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Packaging): Add exec bit for packaged files on Windows #8615

Merged
merged 6 commits into from Dec 14, 2020

Conversation

scadu
Copy link
Contributor

@scadu scadu commented Dec 12, 2020

Closes: #3557

@codecov-io
Copy link

codecov-io commented Dec 12, 2020

Codecov Report

Merging #8615 (5f08945) into master (d102a39) will increase coverage by 0.07%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8615      +/-   ##
==========================================
+ Coverage   86.94%   87.01%   +0.07%     
==========================================
  Files         252      252              
  Lines        9506     9505       -1     
==========================================
+ Hits         8265     8271       +6     
+ Misses       1241     1234       -7     
Impacted Files Coverage Δ
lib/plugins/package/lib/packageService.js 75.45% <50.00%> (+4.86%) ⬆️
lib/plugins/package/lib/zipService.js 96.29% <100.00%> (-0.04%) ⬇️
lib/plugins/standalone/index.js 40.00% <0.00%> (-1.03%) ⬇️
...ib/plugins/aws/package/compile/events/alb/index.js 100.00% <0.00%> (ø)
...ins/aws/package/compile/events/alb/lib/validate.js 95.71% <0.00%> (+0.40%) ⬆️
...ws/package/compile/events/alb/lib/listenerRules.js 84.61% <0.00%> (+0.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d102a39...5f08945. Read the comment docs.

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scadu that looks great! I have just one very minor cleanup suggestion, and it'll be ready to go

lib/plugins/package/lib/packageService.js Outdated Show resolved Hide resolved
Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @scadu !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows: Uploaded binaries cannot be executed
3 participants