Improve schema definition validation to prevent collisions #8655
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8655 +/- ##
==========================================
- Coverage 87.15% 87.15% -0.01%
==========================================
Files 252 252
Lines 9509 9544 +35
==========================================
+ Hits 8288 8318 +30
- Misses 1221 1226 +5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Thanks @fredericbarthelet 🙇 Looks good from my perspective, but as I'm not super familiar with schema engine yet, I'll ask for another review before merging this in
| @@ -290,6 +309,21 @@ class ConfigSchemaHandler { | |||
| } | |||
|
|
|||
| function addPropertiesToSchema(subSchema, extension = { properties: {}, required: [] }) { | |||
| let collidingExtensionPropertyKey; | |||
| const existingSubSchemaPropertiesKeys = Object.keys(subSchema.properties); | |||
| Object.keys(extension.properties).some(extensionPropertiesKey => { | |||
There was a problem hiding this comment.
At first I was thinking why not to throw an error inside the callback, but I've noticed you used some to stop iteration on first colliding property, nice 👍
There was a problem hiding this comment.
@fredericbarthelet looks great! I have just one DX suggestion towards error reporting, as as proposed may result with vague error reports.
fredericbarthelet
force-pushed
the
improve-defineTopLevelProperty
branch
from
2dabcdb
to
a88767b
Compare
|
@medikoo I implemented your suggestions and added test cases for all different location where an error could be thrown :) |
Closes: #8481