feat(AWS API Gateway): Add HttpApiId to httpApi CF Outputs #8664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8664 +/- ##
==========================================
- Coverage 87.08% 87.08% -0.01%
==========================================
Files 253 253
Lines 9511 9547 +36
==========================================
+ Hits 8283 8314 +31
- Misses 1228 1233 +5
Continue to review full report at Codecov.
|
pgrzesik
approved these changes
Dec 23, 2020
pgrzesik
suggested changes
Dec 23, 2020
| @@ -148,6 +148,10 @@ class HttpApiEvents { | |||
| }; | |||
| resource.DependsOn = this.provider.naming.getHttpApiLogGroupLogicalId(); | |||
| } | |||
| this.cfTemplate.Outputs.HttpApi = { | |||
There was a problem hiding this comment.
Sorry for confusion, after a second thought, I think it will be better to keep the same convention as for Url and output it as HttpApiId instead of HttpApi.
There was a problem hiding this comment.
that makes sense, I'll change it
pgrzesik
approved these changes
Dec 23, 2020
pgrzesik
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to the issue: #8650
This tiny PR adds HttpApi output to the cloudformation template when using AWS ApiGateway's httpApi, in addition to the existing HttpApiUrl output.
Closes: #8650