feat(AWS Lambda): Support referencing images with tags #8683
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for referencing images with tags
To also share a bit more context about it because it seems fairly simple, but there was a little bit more consideration to it. I was also wondering if we should resolve SHA for an image at all times, because it seems like ImageUri can also accept an URI with tag only. My first idea here that maybe (without versioning), if ImageUri would be e.g.
xxx.xxx/repo-name:latest
, then after updating the image under thelatest
tag in that repo will result in new Lambdas being invoked with that newly pushed image. I was a bit surprised to learn that it's not the case, it seems like Lambda internally is somehow still pinning the image to specific sha (maybe during the image optimization process that happens before the first invocation) and you have to force update your Lambda function anyway. In that case, I feel like, at this point, we should always resolve the specific SHA of an image.Closes: #8621