Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS CloudFront: Ensure to describe resolved stage in comment #8685

Merged
merged 1 commit into from Dec 29, 2020

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Dec 29, 2020

Discovered when preparing #8684

@codecov
Copy link

codecov bot commented Dec 29, 2020

Codecov Report

Merging #8685 (a52ebcb) into master (ef53050) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8685   +/-   ##
=======================================
  Coverage   87.23%   87.23%           
=======================================
  Files         255      255           
  Lines        9597     9597           
=======================================
  Hits         8372     8372           
  Misses       1225     1225           
Impacted Files Coverage Δ
...b/plugins/aws/package/compile/events/cloudFront.js 95.60% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef53050...c7de1d2. Read the comment docs.

Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch 🙌

@medikoo medikoo merged commit 120bfb7 into master Dec 29, 2020
@medikoo medikoo deleted the 1229-fix-cloudfront-comment branch December 29, 2020 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants