Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use @serverless/utils for cloudformationSchema #8705

Conversation

fredericbarthelet
Copy link
Contributor

Addresses: #8627

Should be merged after serverless/utils#66

@fredericbarthelet fredericbarthelet force-pushed the move-cloudformation-schema-to-utils branch 3 times, most recently from 0afbead to 484ff19 Compare January 6, 2021 10:03
@fredericbarthelet fredericbarthelet force-pushed the move-cloudformation-schema-to-utils branch from 484ff19 to 6510037 Compare January 6, 2021 10:04
@codecov
Copy link

codecov bot commented Jan 6, 2021

Codecov Report

Merging #8705 (6510037) into master (4460383) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8705      +/-   ##
==========================================
- Coverage   87.28%   87.26%   -0.03%     
==========================================
  Files         255      254       -1     
  Lines        9630     9614      -16     
==========================================
- Hits         8406     8390      -16     
  Misses       1224     1224              
Impacted Files Coverage Δ
lib/utils/fs/parse.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4460383...6510037. Read the comment docs.

Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you 🙌

@pgrzesik pgrzesik changed the title Use utils from @serverless/utils for cloudformationSchema refactor: Use @serverless/utils for cloudformationSchema Jan 6, 2021
@pgrzesik pgrzesik merged commit 2efc357 into serverless:master Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants