New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Variables): Add support for Terraform state file parsing #8755
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8755 +/- ##
==========================================
+ Coverage 87.51% 87.59% +0.07%
==========================================
Files 259 259
Lines 9628 9640 +12
==========================================
+ Hits 8426 8444 +18
+ Misses 1202 1196 -6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @bdwyertech, thanks for submitting your PR. Would you be willing to add a test case that covers this specific use case?
Sure, I can give it a try.
…On Thu, Jan 14, 2021, 3:56 AM Piotr Grzesik ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Hello @bdwyertech <https://github.com/bdwyertech>, thanks for submitting
your PR. Would you be willing to add a test case that covers this specific
use case?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#8755 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAWV4WLWR45LRM7ST2GHFZ3SZ2WUXANCNFSM4WBNUXEQ>
.
|
ad084a0
to
7d6a3ae
Compare
Signed-off-by: Brian Dwyer <Brian.Dwyer@broadridge.com>
Tests added @pgrzesik |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @bdwyertech, well done 👍
Terraform state file is JSON. This would add support for cross-referencing Terraform outputs in serverless configuration.