fix(AWS Lambda): Ensure function update works when image used #8786
Conversation
pgrzesik
force-pushed
the
ensure-that-deploy-function-works-properly-for-image
branch
from
9586c88
to
8f4e46b
Compare
Codecov Report
@@ Coverage Diff @@
## master #8786 +/- ##
==========================================
+ Coverage 87.74% 87.76% +0.02%
==========================================
Files 264 264
Lines 9780 9822 +42
==========================================
+ Hits 8581 8620 +39
- Misses 1199 1202 +3
Continue to review full report at Codecov.
|
lib/plugins/aws/deployFunction.js
Outdated
| if (didOneMinutePass) { | ||
| throw new ServerlessError( | ||
| 'Retry timed out. Please try to deploy your function once again.' | ||
| ); | ||
| } |
There was a problem hiding this comment.
I think this belongs within below if condition (otherwise we risk hiding an error that anyway was supposed to be exposed)
lib/plugins/aws/deployFunction.js
Outdated
| 'description' in functionObj && | ||
| !_.isObject(functionObj.description) && |
There was a problem hiding this comment.
I see it reflects the original logic, but as we're updating it, I would improve it:
- In case of string property more natural to check for existence with
functionObj.description - By schema this value can't be an object, so I would skip that check
There was a problem hiding this comment.
Great call, I believe I've applied it whenever it made sense and dropped checks for isObject in places where schema prevents it
lib/plugins/aws/deployFunction.js
Outdated
| 'handler' in functionObj && | ||
| !_.isObject(functionObj.handler) && |
| expect(stdoutData).to.include('Successfully updated function'); | ||
| }); | ||
|
|
||
| it('should cast non-string env variables to strings during update', async () => { |
There was a problem hiding this comment.
Let's skip this test. String coercion is done at configuration validation step. This functionality in all cases receives property values coerced to defined types
pgrzesik
changed the title
pgrzesik
deleted the
ensure-that-deploy-function-works-properly-for-image
branch
In relation to discussion started in #8778.
This PR adds:
updateFunctionConfigurationfails due to another update in progressupdateFunctionCodecall when image did not changeupdateFunctionConfigurationwhen nothing changed/there's nothing to update