fix(CLI): support multiple env options #9131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9131 +/- ##
==========================================
+ Coverage 87.12% 87.14% +0.01%
==========================================
Files 294 294
Lines 11253 11253
==========================================
+ Hits 9804 9806 +2
+ Misses 1449 1447 -2
Continue to review full report at Codecov.
|
terrybondy
reviewed
Mar 16, 2021
| @@ -16,7 +16,7 @@ const baseArgsSchema = { | |||
| }; | |||
|
|
|||
| const resolveArgsSchema = (commandOptionsSchema) => { | |||
| const options = { boolean: new Set(), string: new Set(), alias: new Map() }; | |||
| const options = { boolean: new Set(), string: new Set(), alias: new Map(), multiple: new Set() }; | |||
There was a problem hiding this comment.
terrybondy
reviewed
Mar 16, 2021
| @@ -38,7 +38,7 @@ describe('test/unit/lib/cli/resolve-input.test.js', () => { | |||
| }); | |||
|
|
|||
| it('should recognize --help as boolean', async () => { | |||
| expect(data.options.version).to.equal(true); | |||
| expect(data.options.help).to.equal(true); | |||
terrybondy
approved these changes
Mar 16, 2021
medikoo
approved these changes
Mar 16, 2021
beccslee
pushed a commit
to beccslee/serverless
that referenced
this pull request
Mar 17, 2021
This was referenced Mar 17, 2021
This was referenced Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry about the lack of a Github bug. I can make one if need be. This is my reference, though: https://forum.serverless.com/t/unexpected-multiple-env/14401