Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variables: Fix unresolved sources resolver #9356

Merged
merged 2 commits into from
Apr 23, 2021

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Apr 23, 2021

Closes: #9355

Additionally improved main process flow inline documentation

@codecov
Copy link

codecov bot commented Apr 23, 2021

Codecov Report

Merging #9356 (1b8f87e) into master (154351f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9356   +/-   ##
=======================================
  Coverage   86.95%   86.96%           
=======================================
  Files         317      317           
  Lines       11847    11854    +7     
=======================================
+ Hits        10302    10309    +7     
  Misses       1545     1545           
Impacted Files Coverage Δ
scripts/serverless.js 50.00% <ø> (ø)
...ation/variables/resolve-unresolved-source-types.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 154351f...1b8f87e. Read the comment docs.

@medikoo medikoo requested a review from pgrzesik April 23, 2021 08:05
Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation warning for "self" with "opt:" as variable
2 participants