Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(AWS HTTP API): Ensure to apply tags to stage #9407

Merged
merged 3 commits into from
May 3, 2021

Conversation

filipgolonka
Copy link
Contributor

Closes: #9395

Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @filipgolonka - it looks good 👍 I have just one minor ask - could you please extend the documentation a bit to inform that it also will apply tags to the stage resource?
https://github.com/serverless/serverless/blob/master/docs/providers/aws/events/http-api.md#tags

@codecov
Copy link

codecov bot commented Apr 30, 2021

Codecov Report

Merging #9407 (097f717) into master (d647125) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9407   +/-   ##
=======================================
  Coverage   86.89%   86.90%           
=======================================
  Files         321      321           
  Lines       11959    11963    +4     
=======================================
+ Hits        10392    10396    +4     
  Misses       1567     1567           
Impacted Files Coverage Δ
lib/plugins/aws/package/compile/events/httpApi.js 93.48% <100.00%> (+0.06%) ⬆️
lib/cli/render-help/index.js 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d647125...097f717. Read the comment docs.

@filipgolonka
Copy link
Contributor Author

Thanks for the review @pgrzesik. Yep, it sounds sane to extend the doc - it is done now.

Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @filipgolonka - great job 👏

@pgrzesik pgrzesik changed the title fix(AWS API Gateway): propagate tags to GW stage fix(AWS HTTP API): Ensure to apply tags to stage May 3, 2021
@pgrzesik pgrzesik merged commit 80511a4 into serverless:master May 3, 2021
@filipgolonka filipgolonka deleted the patch-1 branch May 3, 2021 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tags are not applied to HttpApiStage
2 participants