Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Replace fse.readdir with fs.promises.readdir #9780

Merged
merged 1 commit into from Jul 26, 2021

Conversation

sdas13
Copy link
Contributor

@sdas13 sdas13 commented Jul 23, 2021

Addresses: #8605

@codecov
Copy link

codecov bot commented Jul 23, 2021

Codecov Report

Merging #9780 (9164e7f) into master (32de9bf) will decrease coverage by 0.05%.
The diff coverage is 16.66%.

❗ Current head 9164e7f differs from pull request most recent head 8cf57f8. Consider uploading reports for the commit 8cf57f8 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9780      +/-   ##
==========================================
- Coverage   86.18%   86.12%   -0.06%     
==========================================
  Files         330      330              
  Lines       12806    12809       +3     
==========================================
- Hits        11037    11032       -5     
- Misses       1769     1777       +8     
Impacted Files Coverage Δ
lib/Serverless.js 68.75% <0.00%> (-3.10%) ⬇️
scripts/pkg/upload/world.js 0.00% <0.00%> (ø)
lib/utils/telemetry/index.js 78.94% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32de9bf...8cf57f8. Read the comment docs.

@sdas13 sdas13 marked this pull request as ready for review July 23, 2021 16:33
Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sdas13, it looks great 👏

@pgrzesik pgrzesik merged commit 1e00f9e into serverless:master Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants