-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(AWS API Gateway): Ensure consistent default for cors
conf
#9909
fix(AWS API Gateway): Ensure consistent default for cors
conf
#9909
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9909 +/- ##
==========================================
- Coverage 86.25% 86.18% -0.07%
==========================================
Files 330 330
Lines 12879 13005 +126
==========================================
+ Hits 11109 11209 +100
- Misses 1770 1796 +26
Continue to review full report at Codecov.
|
Let it add a test to assert this |
Ready to be reviewed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @issea1015 - looks good, I only have a few minor questions - please let me know what do you think 🙇
test/unit/lib/plugins/aws/package/compile/events/apiGateway/lib/validate.test.js
Outdated
Show resolved
Hide resolved
@pgrzesik Thanks for the feedback :) I will resolve them and let you know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @issea1015 🙇 While the refactoring looks nice, I would rather avoid it, please see my comment about testing and let me know what do you think
test/unit/lib/plugins/aws/package/compile/events/apiGateway/lib/validate.test.js
Outdated
Show resolved
Hide resolved
@pgrzesik Thanks for the guidance! Let me take a look and resolve them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @issea1015 - it looks awesome, there's one last small thing related to test and we're good to go 👍
test/unit/lib/plugins/aws/package/compile/events/apiGateway/lib/validate.test.js
Outdated
Show resolved
Hide resolved
Thank you for all of these kind guidances 👍 👍 @pgrzesik |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @issea1015 👏
cors
conf
Closes: #9858