Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove package-lock.json and shrinkwrap scripts #6280

Merged
merged 2 commits into from
Jun 21, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
*.log *.log
npm-debug.log npm-debug.log
npm-shrinkwrap.json npm-shrinkwrap.json
/package-lock.json


# Runtime data # Runtime data
pids pids
Expand Down
5 changes: 2 additions & 3 deletions RELEASE_CHECKLIST.md
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -20,15 +20,14 @@ milestone if still open
## Prepare Package ## Prepare Package


- [ ] Install the latest `npm` version or Docker container with latest `node` and `npm` (Ensure to work with an `npm` version which is distributed with latest `node` version) - [ ] Install the latest `npm` version or Docker container with latest `node` and `npm` (Ensure to work with an `npm` version which is distributed with latest `node` version)
- [ ] Remove the `node_modules` folder and the `package-lock.json` file and run `npm install` (Removing both ensures that `package-lock.json` is updated with the latest versions of dependencies)
- [ ] Update `CHANGELOG.md` with the content from your clipboard - [ ] Update `CHANGELOG.md` with the content from your clipboard
- [ ] Make sure all files that need to be pushed are included in `package.json -> files` - [ ] Make sure all files that need to be pushed are included in `package.json -> files`
- [ ] Commit your changes (make sure that `package.json`, `package-lock.json` and `CHANGELOG.md` are updated) - [ ] Commit your changes (make sure that `package.json` and `CHANGELOG.md` are updated)
- [ ] Push your branch and open up a new PR - [ ] Push your branch and open up a new PR
- [ ] Await approval and merge the PR into `master` - [ ] Await approval and merge the PR into `master`
- [ ] Go back to the branch you want to release from (e.g. `master`) and pull the changes from GitHub - [ ] Go back to the branch you want to release from (e.g. `master`) and pull the changes from GitHub
- [ ] Make sure there are no local changes to your repository (or reset with `git reset --hard HEAD`) - [ ] Make sure there are no local changes to your repository (or reset with `git reset --hard HEAD`)
- [ ] Check `package.json` and `package-lock.json` version config to make sure it fits what we want to release - [ ] Check `package.json` version config to make sure it fits what we want to release


## Releasing ## Releasing


Expand Down