Using variablesResolutionMode: 20210219 prevents loading external configuration files outside of service folder

[laurynas-karvelis]

Hello,
First of all I wanted to thank everyone involved creating such a great tool!

After upgrading to the latest serverless version 2.30.3 and applying variablesResolutionMode: 20210219 to service serverless.yml in preparation for serverless@v3 causes serverless offline and serverless deploy invocations to throw following error(s) when trying to load configuration files sourced outside serverless main service folder:

Cannot resolve serverless.yml: Variables resolution errored with:
    - Cannot resolve variable at "custom.globals": Cannot load file from outside of service folder

Loading complementary config files from outside service folder usually is very helpful way for developers who maintain mono repos that contain number of individual serverless services where all or some share common configuration values used across the project. Preventing such possibility introduces unnecessary config duplication and unwanted future misconfigurations due to configs being out of sync.

I searched your repository for this error and found a check that causes this error here:

serverless/lib/configuration/variables/sources/file.js

Lines 40 to 45 in 68de8bd

	if (!filePath.startsWith(`${servicePath}${path.sep}`)) {
	throw new ServerlessError(
	'Cannot load file from outside of service folder',
	'FILE_SOURCE_PATH_OUTSIDE_OF_SERVICE'
	);
	}

serverless.yml

service: service-name
variablesResolutionMode: 20210219

provider:
  name: aws
  lambdaHashingVersion: 20201221
  stage: local
custom:
  globals: ${file(../../serverless/globals.yml)}

//node_modules/.bin/serverless offline output

 Serverless Error ----------------------------------------
 
  Cannot resolve serverless.yml: Variables resolution errored with:
    - Cannot resolve variable at "custom.globals": Cannot load file from outside of service folder
 
  Get Support --------------------------------------------
     Docs:          docs.serverless.com
     Bugs:          github.com/serverless/serverless/issues
     Issues:        forum.serverless.com
 
  Your Environment Information ---------------------------
     Operating System:          darwin
     Node Version:              12.20.1
     Framework Version:         2.30.3 (local)
     Plugin Version:            4.5.1
     SDK Version:               4.2.0
     Components Version:        3.7.5
 
error Command failed with exit code 1.

Installed version

Framework Core: 2.30.3 (local)
Plugin: 4.5.1
SDK: 4.2.0
Components: 3.7.5

[medikoo]

@laurynas-karvelis great thanks for report!

Can we consider this as duplicate of #9095 ?

[laurynas-karvelis]

By looking at the ticket you linked it is indeed the same issue. Thanks for such quick response @medikoo!

[medikoo]

Thanks for confirmation.

I'm closing this as duplicate then