Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Site] Add a Hero section #53

Closed
Tracked by #38
Nikhil-Ladha opened this issue Aug 3, 2022 · 12 comments · Fixed by #60
Closed
Tracked by #38

[Site] Add a Hero section #53

Nikhil-Ladha opened this issue Aug 3, 2022 · 12 comments · Fixed by #60

Comments

@Nikhil-Ladha
Copy link
Contributor

Nikhil-Ladha commented Aug 3, 2022

Desired State of the Service Mesh Patterns site

A Hero section needs to be added to the site as per this Figma design.


Contributor Resources

This website uses React and GitHub Pages. Site content is found under the master branch.

@Jonathan-Foo
Copy link
Contributor

Hi @Nikhil-Ladha,
Could I please work on this issue. I also recently filled out the member form and joined the community slack, but still don't have access to the Figma files, if you could help me with that I'll be super grateful. Cheers!

@Nikhil-Ladha
Copy link
Contributor Author

Sure, go ahead.
Can you share your email id so that I can give you access to Figma?

@Jonathan-Foo
Copy link
Contributor

my email is jonathan.foozh@gmail.com. Thank you!

@Nikhil-Ladha
Copy link
Contributor Author

Sent you the invite.

@Jonathan-Foo
Copy link
Contributor

Thank you I'm got in. Can I ask how long do we usually get to complete our issues?

@Nikhil-Ladha
Copy link
Contributor Author

Depends on the task, TBH.
There isn't any hard and fast rule as such, but you should demo your progress eventually. One of the best ways is to have a draft PR with some initial changes and then keep on iterating.

If for a long time there is no update from the assignee, we allow other contributors to take over.

Hopefully, that clears your doubt :)

@Jonathan-Foo
Copy link
Contributor

Okay, thank you for clarifying, and also for your help.

@bhavyastar
Copy link
Contributor

I am working on the hero section @Nikhil-Ladha . It will be completed soon!

@Nikhil-Ladha
Copy link
Contributor Author

Ok, @bhavyastar if you can't send a PR within next 2 days I will have to hand the baton to @Jonathan-Foo

Please hold off for 2 more days @Jonathan-Foo .

@bhavyastar
Copy link
Contributor

Okay for sure @Nikhil-Ladha .

@Jonathan-Foo
Copy link
Contributor

Hi @Nikhil-Ladha I'm so sorry, I only saw this after I completed it and made the pull request. Even if you choose not to use mine, I'll still be super grateful for some feedback.

@bhavyastar
Copy link
Contributor

No issues then @Jonathan-Foo . :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

3 participants