Skip to content
This repository has been archived by the owner on Oct 20, 2023. It is now read-only.

Making Queries Configurable #3

Closed
Pothulapati opened this issue May 27, 2019 · 1 comment · Fixed by #7
Closed

Making Queries Configurable #3

Pothulapati opened this issue May 27, 2019 · 1 comment · Fixed by #7

Comments

@Pothulapati
Copy link
Member

Right Now, The queries are present in the queries.go file and are specific to linkerd.

To make this repo support more implementations, we need a way to make the prom quieries pluggable. This can be solved by having each implementation have a ConfigMap with the queries.

The corresponding ConfigMap is installed and dynamically loaded as a configuration field into Viper during initialisation.

@grampelberg

@Pothulapati
Copy link
Member Author

I will be working on this issue, once this approach is accepted :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant