Skip to content
This repository has been archived by the owner on Oct 20, 2023. It is now read-only.

No warning if incorrect yaml is applied for Traffic Split #235

Closed
1 of 5 tasks
mudit-01 opened this issue Sep 15, 2021 · 1 comment
Closed
1 of 5 tasks

No warning if incorrect yaml is applied for Traffic Split #235

mudit-01 opened this issue Sep 15, 2021 · 1 comment
Labels
proposal Propose changes to the SMI specification

Comments

@mudit-01
Copy link

Describe the proposal

For traffic split, if weights are distributed in an improper way like all weights don't sum up to 100 or all weights sum > 100. We don't get an error message that yaml is incorrect.
Scope

  • New specification
  • Traffic Access Control
  • Traffic Specs
  • Traffic Metrics
  • Traffic Split

Possible use cases

apply the yaml with irregular weights like 1000, -200 etc. the yaml will be applied successfully without error. This should throw an error message.

@mudit-01 mudit-01 added the proposal Propose changes to the SMI specification label Sep 15, 2021
@jbyers19
Copy link
Contributor

Hi, @mudit-01. This was discussed on the SMI community call today and the consensus was that this proposal is outside the scope of this spec. Validation beyond that enforced by the OpenAPI schema in the TrafficSplit CRD is left to those implmenting this spec.

if weights are distributed in an improper way like all weights don't sum up to 100 or all weights sum > 100

The weights are not percentages, so there should be no issue if the weights do not add up to 100.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
proposal Propose changes to the SMI specification
Projects
None yet
Development

No branches or pull requests

3 participants