You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
and this does not reflect the actual calculation, because Transform2D does not transform Point3D or Vector3D, so the w component in the result is always 1.
Furthermore, all matrices are transposed in the Transform2D or Transform3D documentation. Although it is mentioned that Transform2D or Transform3D use column-major order, I think putting transposed matrices without the transpose symbol is counter-intuitive for readers.
At least the following code must be represented as below.
In the doc-comment of
Transform2D
, there is a matrix formula that describes the transformation performed byTransform2D
:euclid/src/transform2d.rs
Lines 51 to 55 in 6b2aece
and this does not reflect the actual calculation, because
Transform2D
does not transformPoint3D
orVector3D
, so thew
component in the result is always 1.Furthermore, all matrices are transposed in the
Transform2D
orTransform3D
documentation. Although it is mentioned thatTransform2D
orTransform3D
use column-major order, I think putting transposed matrices without the transpose symbol is counter-intuitive for readers.At least the following code must be represented as below.
euclid/src/transform2d.rs
Lines 546 to 554 in 6b2aece
The text was updated successfully, but these errors were encountered: