Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundled build with freetype doesn't actually work #235

Open
waywardmonkeys opened this issue Aug 26, 2023 · 3 comments
Open

Bundled build with freetype doesn't actually work #235

waywardmonkeys opened this issue Aug 26, 2023 · 3 comments

Comments

@waywardmonkeys
Copy link
Collaborator

When we build with --features bundled, we need to add this to the harfbuzz-sys/build.rs:

if cfg!(feature = "freetype") {
    cfg.define("HAVE_FREETYPE", "1");
}

Unfortunately, this will fail as we need to set up additional build flags for the build to find freetype (and this is even more unfriendly on Windows).

This gets a bit annoying when freetype is in the default features ...

@mrobinson
Copy link
Member

Maybe for now we can say that Windows only supports directwrite and not freetype?

@waywardmonkeys
Copy link
Collaborator Author

Let me look at this tomorrow and see if I remember what direction I was thinking. I suspect that not having these as default features would be good.

@waywardmonkeys
Copy link
Collaborator Author

(Since I don’t think Servo actually used the platform stuff…)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants