Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nightly warnings related to lifetimes #27

Merged
merged 1 commit into from Sep 2, 2015
Merged

Conversation

frewsxcv
Copy link
Contributor

@frewsxcv frewsxcv commented Sep 2, 2015

The following warnings appear:

src/platform/mod.rs:7:5: 7:56 warning: the trait `core::marker::Sized` is not implemented for the type `Self` [E0277]
src/platform/mod.rs:7     fn create_headless() -> Result<Self, &'static str>;
                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/platform/mod.rs:7:5: 7:56 help: run `rustc --explain E0277` to see a detailed explanation
src/platform/mod.rs:7:5: 7:56 note: `Self` does not have a constant size known at compile-time
src/platform/mod.rs:7     fn create_headless() -> Result<Self, &'static str>;
                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/platform/mod.rs:7:5: 7:56 note: this warning results from recent bug fixes and clarifications; it will become a HARD ERROR in the next release. See RFC 1214 for details.
src/platform/mod.rs:7     fn create_headless() -> Result<Self, &'static str>;
                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/platform/mod.rs:7:5: 7:56 note: required by `core::result::Result`
src/platform/mod.rs:7     fn create_headless() -> Result<Self, &'static str>;
                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

...because of:

rust-lang/rfcs#1214

The following warnings appear:

```
src/platform/mod.rs:7:5: 7:56 warning: the trait `core::marker::Sized` is not implemented for the type `Self` [E0277]
src/platform/mod.rs:7     fn create_headless() -> Result<Self, &'static str>;
                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/platform/mod.rs:7:5: 7:56 help: run `rustc --explain E0277` to see a detailed explanation
src/platform/mod.rs:7:5: 7:56 note: `Self` does not have a constant size known at compile-time
src/platform/mod.rs:7     fn create_headless() -> Result<Self, &'static str>;
                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/platform/mod.rs:7:5: 7:56 note: this warning results from recent bug fixes and clarifications; it will become a HARD ERROR in the next release. See RFC 1214 for details.
src/platform/mod.rs:7     fn create_headless() -> Result<Self, &'static str>;
                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/platform/mod.rs:7:5: 7:56 note: required by `core::result::Result`
src/platform/mod.rs:7     fn create_headless() -> Result<Self, &'static str>;
                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```

...because of:

rust-lang/rfcs#1214
emilio added a commit that referenced this pull request Sep 2, 2015
Fix nightly warnings related to lifetimes
@emilio emilio merged commit 41fb6bf into servo:master Sep 2, 2015
@frewsxcv frewsxcv deleted the rfc-1214 branch September 2, 2015 14:52
@emilio
Copy link
Member

emilio commented Sep 2, 2015

Thanks!
The build errored because travis silently enabled Mac builds, I'll fix it ASAP.

frewsxcv added a commit to frewsxcv/servo that referenced this pull request Sep 2, 2015
bors-servo pushed a commit to servo/servo that referenced this pull request Sep 2, 2015
Upgrade some dependencies to silence warnings

In order to pick up these changes:

* servo/euclid#101
* netvl/xml-rs#102
* mozilla/webdriver-rust#17
* servo/surfman#27

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7513)
<!-- Reviewable:end -->
jrmuizel pushed a commit to jrmuizel/gecko-cinnabar that referenced this pull request Jun 12, 2017
…rom frewsxcv:bump-no-warnings); r=Ms2ger

In order to pick up these changes:

* servo/euclid#101
* netvl/xml-rs#102
* mozilla/webdriver-rust#17
* servo/surfman#27

Source-Repo: https://github.com/servo/servo
Source-Revision: b7c88dd547c01d99c77c90329cc09f13a90a53b7
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Sep 30, 2019
…rom frewsxcv:bump-no-warnings); r=Ms2ger

In order to pick up these changes:

* servo/euclid#101
* netvl/xml-rs#102
* mozilla/webdriver-rust#17
* servo/surfman#27

Source-Repo: https://github.com/servo/servo
Source-Revision: b7c88dd547c01d99c77c90329cc09f13a90a53b7

UltraBlame original commit: 5cbc0613749c34c6cfb1b95223a695776d5c70f9
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 1, 2019
…rom frewsxcv:bump-no-warnings); r=Ms2ger

In order to pick up these changes:

* servo/euclid#101
* netvl/xml-rs#102
* mozilla/webdriver-rust#17
* servo/surfman#27

Source-Repo: https://github.com/servo/servo
Source-Revision: b7c88dd547c01d99c77c90329cc09f13a90a53b7

UltraBlame original commit: 5cbc0613749c34c6cfb1b95223a695776d5c70f9
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 1, 2019
…rom frewsxcv:bump-no-warnings); r=Ms2ger

In order to pick up these changes:

* servo/euclid#101
* netvl/xml-rs#102
* mozilla/webdriver-rust#17
* servo/surfman#27

Source-Repo: https://github.com/servo/servo
Source-Revision: b7c88dd547c01d99c77c90329cc09f13a90a53b7

UltraBlame original commit: 5cbc0613749c34c6cfb1b95223a695776d5c70f9
asajeffrey pushed a commit to asajeffrey/surfman that referenced this pull request Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants