Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for serde 0.9.0 #277

Closed
indiv0 opened this issue Feb 8, 2017 · 2 comments
Closed

Update for serde 0.9.0 #277

indiv0 opened this issue Feb 8, 2017 · 2 comments

Comments

@indiv0
Copy link

indiv0 commented Feb 8, 2017

Would it be possible to bump the serde version in the Cargo.toml to support serde 0.9.0?

@SimonSapin
Copy link
Member

The problem is that that would be a breaking change, we’d need to change the url version number to 2.0.0. Since (for example) Hyper uses url::Url is some of its public APIs, updating it to url 2.0.0 would also be a breaking change and Hyper’s own version number would need to be changed accordingly. Since url is used a lot, this cascading effect is pretty disruptive overall. Maybe you were involved when the libc crate went from 0.1 to 0.2?

For this reason, the plan is to replace the serde support in url itself by the url_serde crate: https://docs.rs/url_serde/ This one already uses 0.9.

@indiv0
Copy link
Author

indiv0 commented Feb 8, 2017

Ah. That makes sense. Thank you for the link :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants