Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Url::parse regression #798

Closed
kellytk opened this issue Oct 11, 2022 · 1 comment
Closed

Url::parse regression #798

kellytk opened this issue Oct 11, 2022 · 1 comment

Comments

@kellytk
Copy link

kellytk commented Oct 11, 2022

let url = url::Url::parse("https://foo.bar.0")?; has a valid URL and was accepted until recently.

Now it generates the error "invalid IPv4 address".

@valenting
Copy link
Collaborator

According to the reference URL parser that is an invalid URL:

https://jsdom.github.io/whatwg-url/#url=aHR0cHM6Ly9mb28uYmFyLjA=&base=YWJvdXQ6Ymxhbms=

The recent release implemented whatwg/url#619 which forbids URLs that end in a number.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants