Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: PPR Forces Load Wait #58

Closed
versecafe opened this issue Jan 29, 2024 · 4 comments
Closed

[Bug]: PPR Forces Load Wait #58

versecafe opened this issue Jan 29, 2024 · 4 comments
Assignees
Labels
bug Something isn't working stale This has gone stale due to inactivity triage New issues get this label, remove it after triage

Comments

@versecafe
Copy link

Provide environment information

OS: MacOS Sonoma
Chip: M3 Pro

Server Runtime: Node 18 LTS
Next Version: 14.1.1-canary.2
Serwist SW & Serwist Next: @latest

Which project is this issue for?

@serwist/next

Link to reproduction - Issues with a link to complete (but minimal) reproduction code help us address them faster

https://github.com/versecafe/serwist-ppr-issue-demo

To reproduce

  1. Make a nextJS project with serwist
  2. add PPR and a suspense boundary to main page
  3. set as a PWA
  4. launch PWA

Describe the bug

When using PPR PWA loads until all content is fetched.

Expected behavior

Should load the HTML shell around suspense boundaries and stream in the new content, same as behaviour when visiting the base web version.

Screenshots (if relevant)

image

Additional information (if relevant)

This may just be an issue with PPR or the PWA spec rather than serwist in which case just let me know and I'll remove this.

@versecafe versecafe added bug Something isn't working triage New issues get this label, remove it after triage labels Jan 29, 2024
@DuCanhGH
Copy link
Member

When a user launches your PWA from the home screen, a splash screen is displayed until the PWA is ready. Seems that changing the behaviour doesn't seem to be possible, unfortunately.

@versecafe
Copy link
Author

When a user launches your PWA from the home screen, a splash screen is displayed until the PWA is ready. Seems that changing the behaviour doesn't seem to be possible, unfortunately.

Unfortunate, I have found a workaround of immediately redirecting them to a new page as PPR functions fine so long as it is not the base page of the PWA but it's a bit annoying

@DuCanhGH
Copy link
Member

DuCanhGH commented Jan 29, 2024

@versecafe cool. That seems to work, so you do you :) There doesn't seem to be another solution... Wondering if you can go and smash a loading.tsx on the page though. I haven't used Next.js for quite some time, so I'm pretty much in the dark about certain stuff regarding it to be honest.

Copy link
Contributor

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale This has gone stale due to inactivity label Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale This has gone stale due to inactivity triage New issues get this label, remove it after triage
Projects
None yet
Development

No branches or pull requests

2 participants