Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot find package 'webpack' #88

Closed
Hemistone opened this issue Feb 20, 2024 · 2 comments
Closed

Cannot find package 'webpack' #88

Hemistone opened this issue Feb 20, 2024 · 2 comments

Comments

@Hemistone
Copy link

Hemistone commented Feb 20, 2024

I got error Cannot find package 'webpack' and I assume you've missed to add npm i -D webpack in the installation part of getting started, since I've found difference on the former package(@ducanh2912/next-pwa - ex npm i @ducanh2912/next-pwa && npm i -D webpack).

npm: {
code: "npm i @serwist/next",
lang: "bash",
},
yarn: {
code: "yarn add @serwist/next",
lang: "bash",
},
pnpm: {
code: "pnpm add @serwist/next",
lang: "bash",
},
bun: {
code: "bun add @serwist/next",
lang: "bash",
},

If you think this is true, maybe I can add several code lines in the docs thorough PR.

@DuCanhGH
Copy link
Member

DuCanhGH commented Feb 20, 2024

image
Well I had assumed that your average package manager would warn you of that.
A PR would be nice. Thanks! Merging to the 9.0.0 branch is preferred for now, fyi :)

Edit: no need. I have removed the dependency on webpack as a package, as in it is no longer required to be manually installed, for @serwist/next in 9.0.0-preview.11 :)

@Hemistone
Copy link
Author

Thx! I'm looking forward to the next major version release 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants