Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Some excel library (for example, Styleframe as python library) outputs excel file which contains
xl/_rels/workbook.xml.rels
file'sTarget
differently as follows.With the current spreadsheet_decoder, it generates error.
How to reproduce
To generate excel file which has the problem, execute the following python file.
With the above file, run the following command.
There will be "data.xlsx" in the same directory.
When read the above file with the current spreadsheet_decoder, it says the following error.
You can use the following file and command to generate the error.
How to fix
When
Target
has absolute path, the variable namenamePath
on the fixed code should not be withxl/$target
buttarget.substring(1)
.Related issue
dotnet/Open-XML-SDK#88
tidyverse/readxl#294