-
-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
External links are not preserved #162
Comments
Yep, this is currently the normal behavior. Anyhow, we plan to add support for external links in the first quater of 2023. The implementation of mPDF is a good start but it's not feature complete and we know situations where it will fail. |
Hi Jan, hope you had a good week so far! Best Regards, |
Thanks for the reminder and sorry for the delay. Can you please provide test files, which we can add to the test-suite? |
Hi Jan, thanks for your quick response. Since the documents are part of an intranet they are confidential. first_file.pdf The first and second file have the same content. The Links in question are "typo3.org" wich links to "https://typo3.org/typo3-cms/" and "TYPO3-Lizenz (GNU/GPL)" which links to "https://typo3.org/typo3-cms/overview/licenses/". In the merged file the link stylings are still present, but the links are gone. The text "typo3.org" is a domain and the PDF still recognize it as a link, but instead of directing to "https://typo3.org/typo3-cms/" it links to "http://typo3.org". Also as a side note our customer noticed a black line at the end of the merged file. Thanks, |
We're already working on it and will push a branch in the next week. We're currently writing tests and we're still open for foreign test documents. Yours is working without a problem. This is an example of several (more special) documents merged + yours: concatenate.pdf I cannot see any black line in your merged_file.pdf? I can only guess that you are using TCPDF which adds empty headers and footers. To disable them, just call:
|
Thanks!
Setting the values worked! |
We just prepared PR #174 which will allow you to import external links with FPDI but I would like to get some tests and feedback before merging this. Thanks! @ww-ysg @wq9578 @JesusLopezMadrid @pionl |
Thanks Jan! I've tested the fix in our development environment and my tests were successfull. |
Hi Jan, we got Feedback from our customer. So far everything worked great. Best Regards, |
PR is merged and a new release will follow in the next days. |
FPDI 2.4.0 with support for import of external links is released ;-) |
It looks like that the FPDI library doesn't preserve external links, see: atgp/factur-x#12 (comment)
In this case a PDF/A document is generated.
Is there any working solution implemented?
The text was updated successfully, but these errors were encountered: