Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize PdfParser::readValue() #22

Closed
JanSlabon opened this issue Sep 13, 2017 · 0 comments
Closed

Optimize PdfParser::readValue() #22

JanSlabon opened this issue Sep 13, 2017 · 0 comments

Comments

@JanSlabon
Copy link
Member

The current readValue() method shall be made private and renamed to readValueByToken($token, $expectedType).

Implement a new readValue() method which will have an optional parameter $expectedType.
Internally it will resolve the first token and forward it to the new private method. It also will forward the $expectedType accordingly.

The checks for the $expectedType have to implemented accordingly.

Code that calls readValue() needs to be optimized to use the $expectedType.

This optimization allows better error handling in faulty PDF files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant