-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: Can we have retry logic applied for HTTP 429 (Rate limiting) #31
Comments
That is a really solid point! I'm not able to do it today. Maybe this or next weekend. If you need it sooner, PRs are welcome :) |
@sethgrid thanks for quick response. I will see if I can manage sometime over the weekend and submit the PR sooner or else will wait for you. |
@sethgrid I have to go through some approval process before submitting the PR. I will submit the PR once I get the approval. |
sounds good; keep me in the loop. If approval doesn't work out, let me know too. |
@sethgrid I just got approval today. I will try to submit my changes ASAP. |
@sethgrid Please let me know your thoughts. We are planning to implement rate limiting on our vault cluster and envconsul, consul-template is one of our main tools to read secrets. As per RFC, we will return 429 in the event of rate limiting. With this feature, envconsul and consul template will retry if pester add 429 in its retry list.
The text was updated successfully, but these errors were encountered: