Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Can we have retry logic applied for HTTP 429 (Rate limiting) #31

Closed
pritamsarkar007 opened this issue Apr 13, 2018 · 6 comments

Comments

@pritamsarkar007
Copy link

@sethgrid Please let me know your thoughts. We are planning to implement rate limiting on our vault cluster and envconsul, consul-template is one of our main tools to read secrets. As per RFC, we will return 429 in the event of rate limiting. With this feature, envconsul and consul template will retry if pester add 429 in its retry list.

@sethgrid
Copy link
Owner

That is a really solid point!
https://github.com/sethgrid/pester/blob/master/pester.go#L280
Seems like a minor update here to also check for that status code would do the trick. Plus an added test.

I'm not able to do it today. Maybe this or next weekend. If you need it sooner, PRs are welcome :)

@pritamsarkar007
Copy link
Author

@sethgrid thanks for quick response. I will see if I can manage sometime over the weekend and submit the PR sooner or else will wait for you.

@pritamsarkar007
Copy link
Author

@sethgrid I have to go through some approval process before submitting the PR. I will submit the PR once I get the approval.

@sethgrid
Copy link
Owner

sounds good; keep me in the loop. If approval doesn't work out, let me know too.

@pritamsarkar007
Copy link
Author

@sethgrid I just got approval today. I will try to submit my changes ASAP.

@pritamsarkar007
Copy link
Author

@sethgrid PR submitted #32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants