Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What the allowed SOKS5A error responses? #60

Open
dimaqq opened this issue Jul 6, 2023 · 0 comments
Open

What the allowed SOKS5A error responses? #60

dimaqq opened this issue Jul 6, 2023 · 0 comments

Comments

@dimaqq
Copy link

dimaqq commented Jul 6, 2023

Ref: tailscale/tailscale#6144

that particular project set up a local SOCKS5A server, which sometimes responds, on upstream error, in a way that this Python client library doesn't like, which yields this backtrace:

python3.10/site-packages/socksio/socks5.py", line 257, in loads
    atype = SOCKS5AType(data[3:4])
  File "/usr/local/lib/python3.10/enum.py", line 385, in __call__
    return cls.__new__(cls, value)
  File "/usr/local/lib/python3.10/enum.py", line 710, in __new__
    raise ve_exc
ValueError: b'\x00' is not a valid SOCKS5AType

Thus the question, if the server somehow rejects the request, is it required to fill in bind address type, address and port, or can those be left blank (zero) if the reply (code) is not zero?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant