Use Github API for listing releases to download #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes TryGhost#3 - Add octonode dependency - Add github.js for fetching github releases - Modify app generator to fetch releases and list them - Fix tests to actually test installation of files
|
Depends on pksunkara/octonode#77 getting merged and published (I'm assuming as 0.4.1) before this should get merged. I made sure the unit tests ran but didn't test much locally so another pair of eyes would be nice. |
|
Nice! I'll watch for that octonode update. |
|
Published octonode v0.4.1 |
|
Looks like octonode was just updated to 0.4.1. |
sethvincent
added a commit
that referenced
this pull request
Dec 10, 2013
Use Github API for listing releases to download
|
I made a few little fixes and pushed to npm as v0.1.0. Thanks @jgable! Test it out and let me know how it goes. |
|
Looks good. Thanks for getting this in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3