[Breaking] Read Version in Build #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add default options and detect currentVersion during the build step.
The way to opt out of this behavior is to include a VERSION.txt in the app, otherwise the file will be created automatically. When a VERSION.txt file exists the treeForPublic build step won't overwrite it.
knownasilya
reviewed
Dec 5, 2021
knownasilya
reviewed
Dec 5, 2021
Co-authored-by: Ilya Radchenko <knownasilya@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The move to service based version detection didn't include the automatic ways a version was currently being detected. I've done a few things here:
config/environment.jsand what can be passed to the component.currentVersionis detected read it fromember-cli-app-version, ifember-cli-app-versionis not installed then read theversioninpackage.json. This behavior used to be opt-in, but I think the combination of allowing the value to be set manually and having opted into installing that addon is sufficient, easy to change back though if I'm wrong.VERSION.txt. This used to be opt-in, however the easiest way to opt out now is just to manually create apublic/VERSION.txtin the app. SincecurrentVersionhas to be manually set this seems like a good default.I also moved all of the configuration default setup into the config hook so it wasn't duplicated in the service.
Most of this is personal preference around what I think good defaults are. Since the config is now read in one place and defaults are applied in the build it's trivial to add back in the original opt-in behavior if I'm wrong about good options here. Just let me know.
Fixes #103