Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interferes with theme colors #5

Closed
c6p opened this issue Mar 13, 2022 · 2 comments
Closed

Interferes with theme colors #5

c6p opened this issue Mar 13, 2022 · 2 comments

Comments

@c6p
Copy link

c6p commented Mar 13, 2022

Hi @sethyuan
Thank you for the plugin.

I'm using bonofix dark theme, though there may be clashes with other themes too. Since bonofix specifies CSS rules more precisely than the plugin, plugin-wrap fails to change the colors.

.dark-theme .content mark {
    color: var(--ls-primary-text-color);
    background: rgb(89, 86, 59);
}

Is there any way to set CSS for mark element without building myself? I guess there is no option for custom CSS in the settings. It may come handy when one wants to change the colors too.

As a workaround, what do you think about adding !important to color and background to override theme defaults.

@sethyuan
Copy link
Owner

I believe there is a way for you to override with your own CSS rules. In your custom.css, write your CSS rules and give them a !important where necessary. This is how I override styles from Themes.

@c6p
Copy link
Author

c6p commented Mar 13, 2022

You are right, custom.css approach is fine.

Even though I have some rules in my custom.css, it didn't occur to me at first. You may want to add it to README as a reminder.

@c6p c6p closed this as completed Mar 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants