Skip to content
This repository has been archived by the owner on Apr 9, 2024. It is now read-only.

Extension Traits for Godot #25

Merged
merged 1 commit into from Oct 27, 2021
Merged

Extension Traits for Godot #25

merged 1 commit into from Oct 27, 2021

Conversation

jacobsky
Copy link
Collaborator

Added extension traits for Ui to allow for simpler integration with Godot Input/InputMap. The individual extension traits are split up into several extensions so that we don't clutter up the functionality and users can use only the portion of the extensions that they need.

This closes #23

setzer22
setzer22 approved these changes Oct 21, 2021
View reviewed changes
Copy link
Owner

@setzer22 setzer22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I'm sure this will prove useful to people wanting to use godot-egui in a more egui-like way 👍

I would perhaps add a note on the readme about this? Other than that, it can be merged right away.

@jacobsky
Copy link
Collaborator Author

That's a good point. I'll work on adding some comments and information in the readme.

@jacobsky
Copy link
Collaborator Author

I just finished adding the information.

@setzer22
Copy link
Owner

Looks good to me! 🙂 Feel free to merge this whenever you want 👍

@jacobsky jacobsky merged commit 8719d47 into setzer22:main Oct 27, 2021
@jacobsky jacobsky deleted the extension_traits branch October 27, 2021 07:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@setzer22 setzer22 setzer22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Godot Extensions Traits for Egui
2 participants
@jacobsky @setzer22