Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should CloudVolume continue supporting Python 2.7? #380

Closed
william-silversmith opened this issue Aug 10, 2020 · 7 comments · Fixed by #383
Closed

Should CloudVolume continue supporting Python 2.7? #380

william-silversmith opened this issue Aug 10, 2020 · 7 comments · Fixed by #383
Labels
policy discussion Discussion of questions pertinent to the community.

Comments

@william-silversmith
Copy link
Contributor

william-silversmith commented Aug 10, 2020

Post your comment below.

Twitter thread: https://twitter.com/thundercloudvol/status/1292912062662873089

@william-silversmith william-silversmith added the question What is going on??? :thinking emoji: label Aug 10, 2020
@nkemnitz
Copy link
Contributor

The 👎 should be read as "Drop support for Python2.7"

  • It's been 8 months since the 5 year grace period for Python2 passed
  • No bug fixes for numpy, google-cloud and other smaller packages available

@fcollman
Copy link
Collaborator

100% agree with Nico. I would be more passive about it in so far as I would no longer make major design decisions with 2.7 in mind, which means In practice it will take some time to have support actually drop. Most important is that you announce dropping of support before you drop it, which is an argument for making that announcement sooner than later.

@william-silversmith
Copy link
Contributor Author

I am inclined to agree. I was planning on supporting Python2.7 until it became a pain technically. I ran into an issue where I was attempting to detect strings vs bytes for computing integrity checks and the python2.7's intermingling of strings and bytes has become a potential headache. So far I've seen 4 no votes and no yes votes. The python2.7 traffic was also low (and perhaps not human) last time I checked. pypistats.org seems to be down at the moment.

@william-silversmith
Copy link
Contributor Author

Seems the unanimous opinion so far is 8:0 drop support. The people that are likely to be affected (if there are any) are likely to not be super active on social media or on this page. We are starting to accumulate a few reasons to drop support, so doing it sooner is better. How would we feel about dropping support at the end of September? I feel like if someone is actually developing Python2.7 code, end of August would force them to scramble.

@william-silversmith
Copy link
Contributor Author

Of course, they could always just use an older version of CloudVolume...

@william-silversmith william-silversmith added policy discussion Discussion of questions pertinent to the community. and removed question What is going on??? :thinking emoji: labels Aug 12, 2020
@william-silversmith
Copy link
Contributor Author

Nico pointed out that it's possible to use the python_requires argument in setup.py. This would prevent py27 users from downloading an incompatible release. With this technique in hand, we can drop py27 support in the next release without compromising backwards compatibility with py27 users.

https://packaging.python.org/guides/distributing-packages-using-setuptools/#python-requires

@william-silversmith
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
policy discussion Discussion of questions pertinent to the community.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants