1D Array of 4 Elements Incorrect

[modaresimr]

An error occurs when using an array of 4 elements

import numpy as np
import cc3d
labels, seg_count = cc3d.connected_components(np.array([[[1,1,1,1]]]), return_N=True)
labels

output:

[1,0,0,0]

expected output:

[1,1,1,1]

[william-silversmith]

Thank you for reporting this! I'll take a look.

[william-silversmith]

This is due to faulty special handling of single rows of foreground for fast processing. It gets confused between the different orientations of arrays. Will issue a fix soon.

[modaresimr]

Thank you :-)

[william-silversmith]

Well, that was a subtle bug. 1D arrays are both C and F contiguous. Some parts of the code were checking for if F else and others were doing if C else and this caused 1D arrays to have problems.

[william-silversmith]

Released a fix in 3.10.3. Check it out!