Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: avocado protection (🥑) #43

Merged
merged 24 commits into from Jun 19, 2020
Merged

feat: avocado protection (🥑) #43

merged 24 commits into from Jun 19, 2020

Conversation

william-silversmith
Copy link
Contributor

@william-silversmith william-silversmith commented Feb 25, 2020

Addresses #40

This will get us to about 70% avocado protection but doesn't seem to fix sliced avocados nor dirty avocados yet. I have some ideas though...

@william-silversmith
Copy link
Contributor Author

william-silversmith commented Jun 14, 2020

Avocado 🥑

image

Double Avocado 🙀 🥑 🥑

image

Can fix this by running the avocado fixer until steady state is reached.

Smashed Avocado 🥑 🔨

image

lmao

Sliced Avocado 🔪 🥑

image

Dirty Avocado 🗑️ 🥑

Inclusions touch the border preventing hole filling from functioning.

image

@william-silversmith
Copy link
Contributor Author

In one sample:

image

@william-silversmith
Copy link
Contributor Author

Actually, some of the smashed avocados will be repaired by this technique, so more like 70% repairable?

@william-silversmith
Copy link
Contributor Author

william-silversmith commented Jun 15, 2020

Looking at the sample again, it's fixing 11 out of 14 completely. Of the three: 2 are "dirty avocados". One has inclusions confined to the border, so it will be fine. One has inclusions that extend into the cell, which is more problematic. The last is a sliced avocado that failed it seems because the slice extended across two slices and blocked 3/6 votes, failing to achieve a majority.

For dirty avocados, maybe we can try painting the wall before filling?

@william-silversmith
Copy link
Contributor Author

There's a bug in fastremap and we'll need to update for this test to work.

@william-silversmith william-silversmith changed the title wip: avocado protection (🥑) feat: avocado protection (🥑) Jun 17, 2020
@william-silversmith
Copy link
Contributor Author

william-silversmith commented Jun 19, 2020

Slow but it seems to mostly work. Dirty avocados won't be fully fixed if the inclusions touch the edges of the box. We're using a fudge factor of 2.5 to try to capture nucleii.

With the latest changes, it looks like 13/14 avocados are fully fixed (93%) with one partially fixed in my test set.

@william-silversmith william-silversmith merged commit 37f76e4 into master Jun 19, 2020
@william-silversmith william-silversmith deleted the wms_avocados branch June 19, 2020 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant