Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merges can happen with unselected supervoxels ids #523

Open
ceesem opened this issue Mar 1, 2021 · 1 comment
Open

Merges can happen with unselected supervoxels ids #523

ceesem opened this issue Mar 1, 2021 · 1 comment

Comments

@ceesem
Copy link

ceesem commented Mar 1, 2021

The merge mode in neuroglancer does not limit merges to be made with selected supervoxels. A mis-click, especially with small processes, can cause a merge into a random unselected neighboring object. This is particularly dangerous because the m key to initiate merge mode is right next to the keys for moving between sections and the activation of merge mode is extremely subtle given its dramatic impact (#471).

Undo will help fix the outcomes of this, but I think would still be proper to require that merges be between selected objects. While one can imagine that imagery continuity is good enough and there may be an argument for allowing this, having to load the object on the other side requires that the proofreader at least look at the segmentation as a preview before doing a merge, which can avoid merging good segmentations into bad highly-erroneous segmentations and I think is good practice anyway.

@fcollman
Copy link
Collaborator

a related change would be to have 'merge mode' provide the user some visual feedback that they are in merge mode... changing the border of the window, or the cursor type, really anything as some misclicks can be because people forgot or accidentally entered merge mode (easy to do when the section buttons <>, are right next to m).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants