Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

train() overwrites the base method of nn.Module #2

Closed
NikEyX opened this issue May 27, 2019 · 1 comment
Closed

train() overwrites the base method of nn.Module #2

NikEyX opened this issue May 27, 2019 · 1 comment

Comments

@NikEyX
Copy link

NikEyX commented May 27, 2019

You may want to rename it, since .train() and .eval() are important methods of the base class, and new people might be picking up a wrong habit here. Just a thought.
@seungeunrho
Copy link
Owner

seungeunrho commented May 27, 2019 •
edited
Loading

I think that is very good advice.
I've never thought about it. I should rename them.
I will update the code soon. Thank you.

@rl-max rl-max mentioned this issue Oct 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@seungeunrho @NikEyX