Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monkey-patch of _serialize_xml not compatible with Python 3.4's ElementTree #52

Closed
exomoxo opened this issue Aug 8, 2014 · 3 comments
Closed

Comments

@exomoxo
Copy link

exomoxo commented Aug 8, 2014

In Python 3.4, a keyword argument was added to ElementTree's _serialize_xml: short_empty_elements. The monkey-patch at https://github.com/seveas/python-hpilo/blob/master/hpilo.py#L85 does not handle keyword arguments.

There's no documentation for _serialize_xml, but the new short_empty_elements argument is documented for other high level methods.

@seveas
Copy link
Owner

seveas commented Aug 8, 2014

I fixed this literally 8 minutes before you reported it 😄

@seveas seveas closed this as completed Aug 8, 2014
@exomoxo
Copy link
Author

exomoxo commented Aug 8, 2014

That's great! I can now safely re-download from pip without having to patch those lines each time.

Thank you :)

@seveas
Copy link
Owner

seveas commented Aug 8, 2014

Not quite yet, the fix is not yet in a released version (it will be in the next few days, maybe even today)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants