Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about personality keys used in USBPorts.kext #61

Closed
JonMcL opened this issue Mar 11, 2022 · 2 comments
Closed

Question about personality keys used in USBPorts.kext #61

JonMcL opened this issue Mar 11, 2022 · 2 comments

Comments

@JonMcL
Copy link

JonMcL commented Mar 11, 2022

I'm attempting to improve my USB situation. I've been using my own version of USBPorts.kext, generated with trial-and-error using Hackintool, but it's far from perfect and I don't think Thunderbolt is working correctly.

When reviewing this repo's USBPorts.kext file I noticed that the IOKitPersonalities use iMacPro19,1 even though PlatformInfo info is iMac19,1.

https://github.com/baughmann/designaire-z390-intel-i9-9900k-opencore/blob/1fcca8f9fb662fe127b2efa6b363940270faf98b/EFI/OC/Kexts/USBPorts.kext/Contents/Info.plist#L25
https://github.com/baughmann/designaire-z390-intel-i9-9900k-opencore/blob/1fcca8f9fb662fe127b2efa6b363940270faf98b/EFI/OC/Kexts/USBPorts.kext/Contents/Info.plist#L212

a. Typo and the keys of "personalities" don't really matter?
b. It's important that they use iMacPro19,1 instead of iMac19,1 for reasons?
c. None of the above?

@seven-of-eleven
Copy link
Owner

Hi @JonMcL I think you're right about the key values. My understanding from creating my own USB map was they needed to match the SMBIOS of you computer. I think the "newer" method being used USBToolbox avoids this as it states

Override any built-in Apple USB maps attaching based on SMBIOS and controller name

but it wasn't used for this kext. As such they should be iMac19,1 and not iMacPro19,1. I'll look into this a bit more to see if I can include 2 personalities (MacPro7,1 and iMac19,1) in the USBPort.kext, otherwise I'll update and rename the old USBPorts.kext as an optional download for those continuing to use iMac19,1.

Thanks for this.

@seven-of-eleven
Copy link
Owner

New USBPorts.kext included in the latest EFI should resolve this issue. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants