Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST][MinGW][Win10] Redis-plus-plus Test under MinGW #50

Closed
dellorogiulio opened this issue Mar 22, 2020 · 3 comments
Closed

[TEST][MinGW][Win10] Redis-plus-plus Test under MinGW #50

dellorogiulio opened this issue Mar 22, 2020 · 3 comments

Comments

@dellorogiulio
Copy link

dellorogiulio commented Mar 22, 2020

Hi @sewenew,
I open an "issue" to keep track of tests under MinGw. Maybe someone is interested in them,

Preface

I'm running redis 4.0 under Windows 10 natively (NO WSL), so I could not test some redis 5.x functionalities. Sorry about that but I was not able to find a Win10-native redis 5.0 distribution.
For this reason, I need to comment out:

  • _test_zpop() (zset_cmds_test.hpp)
  • _test_bzpop() (zset_cmds_test.hpp)
  • _test_stream_cmds() (stream_cmds_test.hpp)
  • _test_group_cmds() (stream_cmds_test.hpp)

Currently I'm not setting up a RedisClaster, I should update this topic once I can test Cluster too.
Trying to run _test_multithreads with pool_opts.size = 10 bring my virtual machine to never ends test.. I tried to leave it runs for about 4 hours but nothing goes further.
Even reducing pool_opts.size = 2 I was not able to terminate thread test.s

TESTS

Testing Redis...
Pass sanity tests
Pass connection commands tests
Pass keys commands tests
Pass string commands tests
Pass list commands tests
Pass hash commands tests
Pass set commands tests
Pass zset commands tests
Pass hyperloglog commands tests
Pass geo commands tests
Pass script commands tests
Pass pubsub tests
Pass pipeline and transaction tests
@sewenew
Copy link
Owner

sewenew commented Mar 23, 2020

Thanks @dellorogiulio ! Great job!

Could you please also share how to build and install redis-plus-plus on MinGW? I'm not sure if the building steps I mentioned in README.md also works on MinGW.

Thanks again!

Regards

@dellorogiulio
Copy link
Author

Hi @sewenew ,
Under MinGw I generally re-build everything from source.
So I clone the hiredis repo, add it as CMake submodule and link it against redis-plus-plus!

@sewenew
Copy link
Owner

sewenew commented Mar 29, 2020

Good! So the install instruction in README works under MinGW. Thanks a lot!

Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants