Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not detect properly music from some mods #37

Open
vAlbum opened this issue Aug 31, 2023 · 4 comments
Open

Do not detect properly music from some mods #37

vAlbum opened this issue Aug 31, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@vAlbum
Copy link

vAlbum commented Aug 31, 2023

i am using the mcci utils mod, so it could just be an issue on that mod's part, but the songs from that mod show up on the list but dont actually play when clicked

@charlyb01 charlyb01 added the bug Something isn't working label Aug 31, 2023
@charlyb01
Copy link
Member

Hello and thank you for the report!
I am currently in vacation, but I will take a look at it as soon as I can 😉

@charlyb01
Copy link
Member

MCCI Utils mod is discontinued and doesn't seem to contain any music. Can you give me more details, or maybe a link to the mod if I didn't find the right one?

@charlyb01
Copy link
Member

Even though I didn't find this with your mod, I actually found out that some music may not be registered properly, though they might be detected in the gui. I need to find out if I can detect music category from json. Otherwise, it will need that developers put their music file in a music folder, just like minecraft folder hierarchy

@charlyb01 charlyb01 added enhancement New feature or request and removed bug Something isn't working labels Oct 28, 2023
@vAlbum
Copy link
Author

vAlbum commented Oct 30, 2023

I saw your reply, I will reply as soon as I get the chance, I just don't want to leave you in the dark

@charlyb01 charlyb01 changed the title not compatible with music from other mods Do not detect properly music from some mods Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants