Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify Windows Build Instructions #1861

Open
mhils opened this issue Mar 30, 2023 · 2 comments · May be fixed by #2139
Open

Clarify Windows Build Instructions #1861

mhils opened this issue Mar 30, 2023 · 2 comments · May be fixed by #2139

Comments

@mhils
Copy link

mhils commented Mar 30, 2023

The "install failed" output on Windows links to a README section which does not exist:

It looks like you're compiling for MSVC but we couldn't detect an OpenSSL
installation. If there isn't one installed then you can try the rust-openssl
README for more information about how to download precompiled binaries of
OpenSSL:
https://github.com/sfackler/rust-openssl#windows

https://docs.rs/openssl/latest/openssl/ hints that vcpkg is one of the recommended options, and indeed running

vcpkg install --triplet=x64-windows-static-md openssl

does work as expected (although I first had to figure out that I need to supply --triplet).

I'm happy to send a PR to update either error message or add a README section if someone lets me know what would be preferred. :)

@timzaak
Copy link

timzaak commented May 23, 2023

Both is ok, but I would try to read the error message firstly, and then read readme and search windows in this project issue.

@indirection42
Copy link

Vote for it🙋. This issue really help me a lot. Before that, I have been searched the SO and installed other packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants