New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed macros to work on stable (with proc-macro-hack) #149
Conversation
@dtolnay is the missing documentation warning expected? |
Yes, you have to write the documentation. ;) /// ...
#[cfg(feature = "macros")]
#[proc_macro_hack]
pub use phf_macros::phf_map;
... |
What is blocking you from merging this and stabilizing it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM minus the version number edits.
f6247b1
to
4fc0d1a
Compare
Reverted the version bump, rebased on master, and added some documentation on the macros. Also added a field in Remaining question: should the |
We've technically bumped the minimum to 1.31 now but that's mostly to use |
I can make that change myself, thanks for your contribution! |
I'm glad I could help. Now updating the |
Yep. |
proc-macro-hack
-based (much simpler) reimplementation of #148, to address #106